Skip to content

Commit

Permalink
ARM: tegra: only enable SCU on Tegra20
Browse files Browse the repository at this point in the history
The non-SPL build of U-Boot on Tegra only runs on a single CPU, and
hence there is no need to enable the SCU when running U-Boot. If an
SMP OS is booted, and it needs the SCU enabled, it will enable the SCU
itself. U-Boot doing so is redundant.

The one exception is Tegra20, where an enabled SCU is required for some
aspects of PCIe to work correctly.

Some Tegra SoCs contain CPUs without a software-controlled SCU. In this
case, attempting to turn it on actively causes problems. This is the case
for Tegra114. For example, when running Linux, the first (or at least
some very early) user-space process will trigger the following kernel
message:

Unhandled fault: imprecise external abort (0x406) at 0x00000000

This is typically accompanied by that process receving a fatal signal,
and exiting. Since this process is usually pid 1, this causes total
system boot failure.

Signed-off-by: Tom Warren <[email protected]>
[swarren, fleshed out description, ported to upstream chipid APIs]
Signed-off-by: Stephen Warren <[email protected]>
Signed-off-by: Tom Warren <[email protected]>
  • Loading branch information
tomcwarren committed Jun 6, 2013
1 parent 4596dcc commit dbc000b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arch/arm/cpu/tegra-common/ap.c
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ static void enable_scu(void)
struct scu_ctlr *scu = (struct scu_ctlr *)NV_PA_ARM_PERIPHBASE;
u32 reg;

/* Only enable the SCU on T20/T25 */
if (tegra_get_chip() != CHIPID_TEGRA20)
return;

/* If SCU already setup/enabled, return */
if (readl(&scu->scu_ctrl) & SCU_CTRL_ENABLE)
return;
Expand Down

0 comments on commit dbc000b

Please sign in to comment.