This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
forked from airbytehq/airbyte
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🎉 New Destination: AWS Datalake (airbytehq#10760)
* Implementation of a destination connector for AWS Datalake (governed tables) * refactor * state message * correct source config * add connector spec config * update docs * modify spec json * run seed config Co-authored-by: marcosmarxm <[email protected]>
- Loading branch information
1 parent
fede479
commit e3523e0
Showing
22 changed files
with
1,685 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
airbyte-integrations/connectors/destination-aws-datalake/.dockerignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
* | ||
!Dockerfile | ||
!main.py | ||
!destination_aws_datalake | ||
!setup.py | ||
!boto3-preview |
17 changes: 17 additions & 0 deletions
17
airbyte-integrations/connectors/destination-aws-datalake/Dockerfile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
FROM python:3.7-slim | ||
# FROM python:3.7.11-alpine3.14 | ||
|
||
# Bash is installed for more convenient debugging. | ||
# RUN apt-get update && apt-get install -y bash && rm -rf /var/lib/apt/lists/* | ||
|
||
WORKDIR /airbyte/integration_code | ||
COPY destination_aws_datalake ./destination_aws_datalake | ||
COPY main.py ./ | ||
COPY setup.py ./ | ||
RUN pip install . | ||
|
||
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" | ||
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] | ||
|
||
LABEL io.airbyte.version=0.1.0 | ||
LABEL io.airbyte.name=airbyte/destination-aws-datalake |
160 changes: 160 additions & 0 deletions
160
airbyte-integrations/connectors/destination-aws-datalake/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,160 @@ | ||
# Aws Datalake Destination | ||
|
||
This is the repository for the Aws Datalake destination connector, written in Python. | ||
For information about how to use this connector within Airbyte, see [the documentation](https://docs.airbyte.io/integrations/destinations/aws-datalake). | ||
|
||
## Local development | ||
|
||
### Prerequisites | ||
|
||
**To iterate on this connector, make sure to complete this prerequisites section.** | ||
|
||
#### Minimum Python version required `= 3.7.0` | ||
|
||
#### Build & Activate Virtual Environment and install dependencies | ||
|
||
From this connector directory, create a virtual environment: | ||
|
||
```bash | ||
python -m venv .venv | ||
``` | ||
|
||
This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your | ||
development environment of choice. To activate it from the terminal, run: | ||
|
||
```bash | ||
source .venv/bin/activate | ||
pip install -r requirements.txt | ||
``` | ||
|
||
If you are in an IDE, follow your IDE's instructions to activate the virtualenv. | ||
|
||
Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is | ||
used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`. | ||
If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything | ||
should work as you expect. | ||
|
||
#### Building via Gradle | ||
|
||
From the Airbyte repository root, run: | ||
|
||
```bash | ||
./gradlew :airbyte-integrations:connectors:destination-aws-datalake:build | ||
``` | ||
|
||
#### Create credentials | ||
|
||
**If you are a community contributor**, follow the instructions in the [documentation](https://docs.airbyte.io/integrations/destinations/aws-datalake) | ||
to generate the necessary credentials. Then create a file `secrets/config.json` conforming to the `destination_aws_datalake/spec.json` file. | ||
Note that the `secrets` directory is gitignored by default, so there is no danger of accidentally checking in sensitive information. | ||
See `integration_tests/sample_config.json` for a sample config file. | ||
|
||
**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `destination aws-datalake test creds` | ||
and place them into `secrets/config.json`. | ||
|
||
### Locally running the connector | ||
|
||
```bash | ||
python main.py spec | ||
python main.py check --config secrets/config.json | ||
python main.py discover --config secrets/config.json | ||
python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json | ||
``` | ||
|
||
### Locally running the connector docker image | ||
|
||
#### Build | ||
|
||
First, make sure you build the latest Docker image: | ||
|
||
```bash | ||
docker build . -t airbyte/destination-aws-datalake:dev | ||
``` | ||
|
||
You can also build the connector image via Gradle: | ||
|
||
```bash | ||
./gradlew :airbyte-integrations:connectors:destination-aws-datalake:airbyteDocker | ||
``` | ||
|
||
When building via Gradle, the docker image name and tag, respectively, are the values of the `io.airbyte.name` and `io.airbyte.version` `LABEL`s in | ||
the Dockerfile. | ||
|
||
#### Run | ||
|
||
Then run any of the connector commands as follows: | ||
|
||
```bash | ||
docker run --rm airbyte/destination-aws-datalake:dev spec | ||
docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-aws-datalake:dev check --config /secrets/config.json | ||
# messages.jsonl is a file containing line-separated JSON representing AirbyteMessages | ||
cat messages.jsonl | docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/destination-aws-datalake:dev write --config /secrets/config.json --catalog /integration_tests/configured_catalog.json | ||
``` | ||
|
||
## Testing | ||
|
||
Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named. | ||
|
||
First install test dependencies into your virtual environment: | ||
|
||
```bash | ||
pip install .[tests] | ||
``` | ||
|
||
### Unit Tests | ||
|
||
To run unit tests locally, from the connector directory run: | ||
|
||
```bash | ||
python -m pytest unit_tests | ||
``` | ||
|
||
### Integration Tests | ||
|
||
There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all destination connectors) and custom integration tests (which are specific to this connector). | ||
|
||
#### Custom Integration tests | ||
|
||
Place custom tests inside `integration_tests/` folder, then, from the connector root, run | ||
|
||
```bash | ||
python -m pytest integration_tests | ||
``` | ||
|
||
#### Acceptance Tests | ||
|
||
Coming soon: | ||
|
||
### Using gradle to run tests | ||
|
||
All commands should be run from airbyte project root. | ||
To run unit tests: | ||
|
||
```bash | ||
./gradlew :airbyte-integrations:connectors:destination-aws-datalake:unitTest | ||
``` | ||
|
||
To run acceptance and custom integration tests: | ||
|
||
```bash | ||
./gradlew :airbyte-integrations:connectors:destination-aws-datalake:integrationTest | ||
``` | ||
|
||
## Dependency Management | ||
|
||
All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development. | ||
|
||
We split dependencies between two groups, dependencies that are: | ||
|
||
* required for your connector to work need to go to `MAIN_REQUIREMENTS` list. | ||
* required for the testing need to go to `TEST_REQUIREMENTS` list | ||
|
||
### Publishing a new version of the connector | ||
|
||
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what? | ||
|
||
1. Make sure your changes are passing unit and integration tests. | ||
1. Bump the connector version in `Dockerfile` -- just increment the value of the `LABEL io.airbyte.version` appropriately (we use [SemVer](https://semver.org/)). | ||
1. Create a Pull Request. | ||
1. Pat yourself on the back for being an awesome contributor. | ||
1. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master. |
20 changes: 20 additions & 0 deletions
20
airbyte-integrations/connectors/destination-aws-datalake/build.gradle
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
plugins { | ||
id 'application' | ||
id 'airbyte-docker' | ||
id 'airbyte-integration-test-java' | ||
} | ||
|
||
dependencies { | ||
// https://mvnrepository.com/artifact/com.google.guava/guava | ||
implementation 'com.google.guava:guava:30.1.1-jre' | ||
|
||
// https://mvnrepository.com/artifact/software.amazon.awssdk/athena | ||
implementation 'software.amazon.awssdk:athena:2.17.42' | ||
|
||
// https://mvnrepository.com/artifact/software.amazon.awssdk/glue | ||
implementation 'software.amazon.awssdk:glue:2.17.42' | ||
|
||
|
||
integrationTestJavaImplementation project(':airbyte-integrations:bases:standard-destination-test') | ||
integrationTestJavaImplementation project(':airbyte-integrations:connectors:destination-aws-datalake') | ||
} |
26 changes: 26 additions & 0 deletions
26
...yte-integrations/connectors/destination-aws-datalake/destination_aws_datalake/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# MIT License | ||
# | ||
# Copyright (c) 2020 Airbyte | ||
# | ||
# Permission is hereby granted, free of charge, to any person obtaining a copy | ||
# of this software and associated documentation files (the "Software"), to deal | ||
# in the Software without restriction, including without limitation the rights | ||
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
# copies of the Software, and to permit persons to whom the Software is | ||
# furnished to do so, subject to the following conditions: | ||
# | ||
# The above copyright notice and this permission notice shall be included in all | ||
# copies or substantial portions of the Software. | ||
# | ||
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
# SOFTWARE. | ||
|
||
|
||
from .destination import DestinationAwsDatalake | ||
|
||
__all__ = ["DestinationAwsDatalake"] |
Oops, something went wrong.