Fix ClassCastException with overloaded setters if the metaclass overr…

…ides a multisetter
doyoga52 · Nov 20, 2014 · 334325c · 334325c
1 parent 7e918d1
commit 334325c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/main/groovy/lang/MetaClassImpl.java b/src/main/groovy/lang/MetaClassImpl.java
@@ -2545,6 +2545,8 @@ public void addMetaBeanProperty(MetaBeanProperty mp) {
             if (old != null) {
                 if (old instanceof MetaBeanProperty) {
                     field = ((MetaBeanProperty) old).getField();
+                } else if (old instanceof MultipleSetterProperty) {
+                    field = ((MultipleSetterProperty)old).getField();
                 } else {
                     field = (CachedField) old;
                 }

diff --git a/src/test/groovy/PropertyTest.groovy b/src/test/groovy/PropertyTest.groovy
@@ -232,7 +232,22 @@ class PropertyTest extends GroovyTestCase {
             assert a.x == "3"
         '''
     }
-
+
+    void testOverrideMultiSetterThroughMetaClass() {
+        assertScript '''
+        class A {
+            private String field
+            void setConstraints(Closure cl) {}
+            void setConstraints(String s) {}
+            String getField() { field }
+        }
+
+        A.metaClass.setConstraints = { delegate.field = it+it }
+        def a = new A()
+        a.constraints = '100'
+        assert a.field == '100100'
+        '''
+    }
 }
 
 class Base {