Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add facade eslint #4297

Merged
merged 9 commits into from
Dec 13, 2024
Merged

chore: add facade eslint #4297

merged 9 commits into from
Dec 13, 2024

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Dec 13, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 13, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 13, 2024

Playwright test results

passed  19 passed
flaky  1 flaky

Details

stats  20 tests across 9 suites
duration  5 minutes, 28 seconds
commit  81a25e9
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

@hexf00 hexf00 marked this pull request as ready for review December 13, 2024 10:36
@hexf00 hexf00 requested a review from jikkai as a code owner December 13, 2024 10:36
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.64%. Comparing base (2502caf) to head (81a25e9).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets/src/facade/f-workbook.ts 0.00% 4 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4297      +/-   ##
==========================================
- Coverage   33.65%   33.64%   -0.02%     
==========================================
  Files        2499     2499              
  Lines      128490   128490              
  Branches    28783    28783              
==========================================
- Hits        43246    43225      -21     
- Misses      85244    85265      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great.

@hexf00 hexf00 merged commit 6bb96cc into dev Dec 13, 2024
9 checks passed
@hexf00 hexf00 deleted the chore/facade-eslint branch December 13, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants