Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): facade api #4322

Merged
merged 9 commits into from
Dec 18, 2024
Merged

feat(image): facade api #4322

merged 9 commits into from
Dec 18, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Dec 17, 2024

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@DR-Univer DR-Univer requested a review from wzhudev as a code owner December 17, 2024 03:34
Copy link

github-actions bot commented Dec 17, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 17, 2024

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 46 seconds
commit  740ad2b
info  For more information, see full report

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 311 lines in your changes missing coverage. Please review.

Project coverage is 33.38%. Comparing base (ceff4eb) to head (740ad2b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../sheets-drawing-ui/src/facade/f-over-grid-image.ts 0.00% 147 Missing ⚠️
...ckages/sheets-drawing-ui/src/facade/f-worksheet.ts 0.00% 82 Missing ⚠️
packages/core/src/facade/f-blob.ts 0.00% 39 Missing ⚠️
...ets-ui/src/services/utils/drawing-position-util.ts 0.00% 34 Missing ⚠️
...sheets-drawing-ui/src/basics/transform-position.ts 0.00% 5 Missing ⚠️
packages/core/src/facade/f-univer.ts 0.00% 2 Missing ⚠️
...ervices/selection/base-selection-render.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4322      +/-   ##
==========================================
- Coverage   33.46%   33.38%   -0.08%     
==========================================
  Files        2511     2514       +3     
  Lines      129518   129809     +291     
  Branches    28969    29004      +35     
==========================================
  Hits        43338    43338              
- Misses      86180    86471     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DR-Univer DR-Univer merged commit b41e499 into dev Dec 18, 2024
9 checks passed
@DR-Univer DR-Univer deleted the DR-Univer/over-grid-image-api-v2 branch December 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants