Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some bugs on clipboard facade API #4332

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix: some bugs on clipboard facade API #4332

merged 2 commits into from
Dec 18, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Dec 18, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 18, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  b0edbac
info  For more information, see full report

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.38%. Comparing base (2763f02) to head (b0edbac).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/facade/f-hooks.ts 0.00% 1 Missing ⚠️
...ges/ui/src/services/clipboard/clipboard.command.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4332   +/-   ##
=======================================
  Coverage   33.38%   33.38%           
=======================================
  Files        2514     2514           
  Lines      129813   129815    +2     
  Branches    29005    29005           
=======================================
+ Hits        43335    43338    +3     
+ Misses      86478    86477    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz merged commit 4b51483 into dev Dec 18, 2024
9 checks passed
@yuhongz yuhongz deleted the feat/fix-clipboard-api branch December 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants