Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy cell should generate html & plain #4366

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Dec 26, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 26, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Dec 26, 2024

Playwright test results

passed  20 passed
flaky  1 flaky

Details

stats  21 tests across 10 suites
duration  5 minutes, 27 seconds
commit  12e6900
info  For more information, see full report

Flaky tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 33.38%. Comparing base (57467da) to head (12e6900).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/sheets/worksheet.ts 0.00% 14 Missing ⚠️
packages/core/src/sheets/util.ts 0.00% 2 Missing ⚠️
...ets-ui/src/services/clipboard/clipboard.service.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4366      +/-   ##
==========================================
- Coverage   33.38%   33.38%   -0.01%     
==========================================
  Files        2529     2529              
  Lines      130299   130317      +18     
  Branches    29076    29082       +6     
==========================================
+ Hits        43503    43508       +5     
- Misses      86796    86809      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky requested a review from wzhudev December 26, 2024 11:40
@wzhudev wzhudev merged commit e2edd07 into dev Dec 26, 2024
9 checks passed
@wzhudev wzhudev deleted the fix-copy-plain-numfmt branch December 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants