Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better comments #4377

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore: better comments #4377

merged 1 commit into from
Dec 27, 2024

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Dec 27, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  21 passed

Details

stats  21 tests across 10 suites
duration  4 minutes, 45 seconds
commit  4672a9b
info  For more information, see full report

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 33.35%. Comparing base (70f82d0) to head (4672a9b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 5 Missing ⚠️
packages/sheets-ui/src/facade/f-worksheet.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4377   +/-   ##
=======================================
  Coverage   33.35%   33.35%           
=======================================
  Files        2529     2529           
  Lines      130387   130387           
  Branches    29098    29098           
=======================================
  Hits        43493    43493           
  Misses      86894    86894           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku requested a review from hexf00 December 27, 2024 09:18
@lumixraku lumixraku merged commit 2dd1c2c into dev Dec 27, 2024
9 checks passed
@lumixraku lumixraku deleted the fix/disable-selection branch December 27, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants