Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pointer event #4456

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: pointer event #4456

merged 1 commit into from
Jan 13, 2025

Conversation

lumixraku
Copy link
Contributor

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 10, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 10, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 16 seconds
commit  0cfe662
info  For more information, see full report

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.

Project coverage is 32.57%. Comparing base (88a0c86) to head (0cfe662).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/sheets-ui/src/facade/f-workbook.ts 0.00% 53 Missing ⚠️
packages/sheets/src/facade/f-workbook.ts 0.00% 18 Missing ⚠️
packages/sheets-ui/src/facade/f-event.ts 0.00% 15 Missing ⚠️
packages/sheets/src/facade/f-worksheet.ts 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4456      +/-   ##
==========================================
- Coverage   32.60%   32.57%   -0.04%     
==========================================
  Files        2575     2575              
  Lines      133708   133802      +94     
  Branches    29741    29750       +9     
==========================================
- Hits        43602    43581      -21     
- Misses      90106    90221     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumixraku lumixraku marked this pull request as draft January 10, 2025 03:35
@lumixraku lumixraku force-pushed the fix/pointer-event branch 2 times, most recently from a5c3b76 to 24be753 Compare January 10, 2025 03:39
@lumixraku lumixraku marked this pull request as ready for review January 10, 2025 03:53
@lumixraku lumixraku force-pushed the fix/pointer-event branch 2 times, most recently from bc889ab to 33d2ed0 Compare January 13, 2025 09:41
@lumixraku lumixraku merged commit 58d8551 into dev Jan 13, 2025
9 checks passed
@lumixraku lumixraku deleted the fix/pointer-event branch January 13, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants