Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add hooks after permission set #4459

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Jan 11, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 11, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 11, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 14 seconds
commit  550dc9f
info  For more information, see full report

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.59%. Comparing base (b1e4ae8) to head (550dc9f).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ers/permission/sheet-permission-init.controller.ts 0.00% 2 Missing ⚠️
packages/sheets/src/facade/f-permission.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4459      +/-   ##
==========================================
- Coverage   32.61%   32.59%   -0.02%     
==========================================
  Files        2575     2575              
  Lines      133699   133703       +4     
  Branches    29740    29740              
==========================================
- Hits        43602    43581      -21     
- Misses      90097    90122      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky merged commit f5d97eb into dev Jan 11, 2025
9 checks passed
@ybzky ybzky deleted the chore/add-hooks-after-permission-set branch January 11, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants