Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(facade): insert empty text error #4465

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix(facade): insert empty text error #4465

merged 1 commit into from
Jan 13, 2025

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 13, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@weird94 weird94 requested a review from wzhudev as a code owner January 13, 2025 08:55
Copy link

github-actions bot commented Jan 13, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 merged commit 88a0c86 into dev Jan 13, 2025
9 checks passed
@weird94 weird94 deleted the fix/insert-empty-text branch January 13, 2025 08:58
Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 14 seconds
commit  fc67e64
info  For more information, see full report

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.60%. Comparing base (fcf5bbf) to head (fc67e64).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ages/core/src/docs/data-model/rich-text-builder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4465      +/-   ##
==========================================
- Coverage   32.61%   32.60%   -0.01%     
==========================================
  Files        2575     2575              
  Lines      133707   133708       +1     
  Branches    29740    29741       +1     
==========================================
  Hits        43602    43602              
- Misses      90105    90106       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants