Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subclass hook for additional data transformation to Presto cursor class. #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jezdez
Copy link

@jezdez jezdez commented Jul 10, 2018

This is a follow-up of #82 which proposed a backward-incompatible change
for the strucutre of data returned by the Presto cursor and simplifies
doing additional data transformation without having to override the majority
of the response processing method.

The purpose of this is being able to extend Redash's (https://redash.io)
Presto query runner to show more human-readable query results.

I've signed the Dropbox CLA.

@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #222 into master will decrease coverage by 0.06%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   93.94%   93.88%   -0.07%     
==========================================
  Files          14       14              
  Lines        1487     1504      +17     
  Branches      159      159              
==========================================
+ Hits         1397     1412      +15     
- Misses         64       66       +2     
  Partials       26       26
Impacted Files Coverage Δ
pyhive/presto.py 93.7% <100%> (+0.08%) ⬆️
pyhive/tests/test_presto.py 98.4% <86.66%> (-1.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d19cb0c...8ed1864. Read the comment docs.

… class.

This is basically a follow-up of dropbox#82 which proposed a backward-incompatible change for the structure of data returned by the Presto cursor and simplifies doing additional data transformation without having to override the majority of the response processing method.
@jezdez
Copy link
Author

jezdez commented Nov 8, 2018

@gsilk Hey there, I was wondering if there is anything else needed for this to be reviewed?

@jezdez
Copy link
Author

jezdez commented Nov 29, 2018

Is anyone else interested in reviewing this at Dropbox?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants