Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience method Dry::Configurable::Settings#replace #117

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add convenience method Dry::Configurable::Settings#replace #117

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
aff8705
replace settings
skinnyjames Jul 4, 2021
5352a89
fix formatting
skinnyjames Jul 4, 2021
25d7621
remove whitespace
skinnyjames Jul 4, 2021
b4c6371
rubocop fixes
skinnyjames Jul 20, 2021
f2cc033
attempt at merge
skinnyjames Jul 20, 2021
c8853d8
merge settings
skinnyjames Jul 20, 2021
acf53fd
empty line after guard clause
skinnyjames Jul 20, 2021
2e435c1
trailing whitespace
skinnyjames Jul 20, 2021
58adf9b
remove replace, add Settings#merge, and Settings#merge!
skinnyjames Jul 22, 2021
bf1cb1b
missing spec
skinnyjames Jul 22, 2021
fb26421
use target settings
skinnyjames Jul 23, 2021
06932b7
failing tests when the config has been invoked
skinnyjames Jul 23, 2021
a153da9
merge non nested settings to nested settings
skinnyjames Jul 23, 2021
40423c5
fix linting
skinnyjames Jul 23, 2021
16238c9
add replace back
skinnyjames Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
empty line after guard clause
  • Loading branch information
@skinnyjames
skinnyjames committed Jul 20, 2021
commit acf53fdec3ad077c567810ccb0cd698d173a1a4f
1 change: 1 addition & 0 deletions lib/dry/configurable/settings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def merge(settings)
unless settings.is_a? Dry::Configurable::Settings
raise ArgumentError, "settings must be a Dry::Configurable::Settings"
end

settings.each do |setting|
merge_setting(setting)
end
Expand Down