Rename manual registrar to manifest registrar #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to reserve the term "manual registration" for any instance of a user directly calling `#register` on the container.
timriley
force-pushed
the
rename-manual-registrar-to-manifest-registrar
branch
from
65a3bb1 to
ecd3935
Compare
flash-gordon
approved these changes
Jan 14, 2022
solnic
approved these changes
Jan 14, 2022
alassek
added a commit
to alassek/dry-system
that referenced
this pull request
Jun 13, 2022
`#finalize!` is sending the basename directly to `#call`, which expects a Dry::System::Identifier. This means that if you configure a `registrations_dir`, putting any file in that directory will lead to an exception during finalization. This appears to have been introduced during dry-rb#208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to reserve the term "manual registration" for any instance of a user directly calling
#registeron the container.I think this is the last of the renames coming out of my glossary in #198.