Fix Bootsnap to work with Ruby 3.0 #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash-gordon
reviewed
Feb 8, 2023
lib/dry/system/plugins/bootsnap.rb
Outdated
| end | ||
|
|
||
| # @api private | ||
| def bootsnap_available? | ||
| RUBY_ENGINE == "ruby" && RUBY_VERSION >= "2.3.0" && RUBY_VERSION < "3.1.0" | ||
| RUBY_ENGINE == "ruby" && RUBY_VERSION >= "3.0.0" && RUBY_VERSION < "3.1.0" |
There was a problem hiding this comment.
shouldn't the upper bound be removed? 🤔
There was a problem hiding this comment.
Oh sure, removed the < 3.1.0 condition
|
@RicardoTrindade something's broken in CI? Mind to take a look? |
RicardoTrindade
force-pushed
the
bootsnap_fix
branch
from
8fb9f0d to
50c3f39
Compare
RicardoTrindade
commented
Feb 14, 2023
| @@ -5,11 +5,9 @@ module System | |||
| module Plugins | |||
| module Bootsnap | |||
| DEFAULT_OPTIONS = { | |||
| load_path_cache: true, | |||
| disable_trace: true, | |||
| load_path_cache: false, | |||
There was a problem hiding this comment.
had to change this from true to false to get CI passing once again. with the option as true, some specs would fail with the error below that I haven't been able to figure out what is causing it
11) Container / Imports / Exports exports configured as a list of keys importing container is lazy loading does not finalize either container
Failure/Error: raise ComponentNotLoadableError.new(component, e)
Dry::System::ComponentNotLoadableError:
Component 'exportable_component_a' is not loadable.
Looking for Test::ExportableComponentA.
Did you mean? ExternalComponents
raise ComponentNotLoadableError.new(component, e)
^^^^^
# ./lib/dry/system/loader.rb:71:in `rescue in constant'
# ./lib/dry/system/loader.rb:64:in `constant'
# ./lib/dry/system/loader.rb:49:in `call'
# ./lib/dry/system/component.rb:64:in `instance'
# ./lib/dry/system/container.rb:639:in `block in load_local_component'
# ./lib/dry/system/container.rb:493:in `resolve'
# ./lib/dry/system/container.rb:516:in `key?'
# ./lib/dry/system/importer.rb:109:in `block in build_merge_container'
# ./lib/dry/system/importer.rb:108:in `each'
# ./lib/dry/system/importer.rb:108:in `each_with_object'
# ./lib/dry/system/importer.rb:108:in `build_merge_container'
# ./lib/dry/system/importer.rb:86:in `import_keys'
# ./lib/dry/system/importer.rb:69:in `import'
# ./lib/dry/system/container.rb:648:in `load_imported_component'
# ./lib/dry/system/container.rb:626:in `load_component'
# ./lib/dry/system/container.rb:491:in `resolve'
# ./spec/integration/container/importing/exports_spec.rb:76:in `block (4 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# NameError:
# uninitialized constant Test::ExportableComponentA
#
# Object.const_get(input, false)
# ^^^^^^^^^^
# Did you mean? ExternalComponents
# ./lib/dry/system/loader.rb:67:in `constant'
RicardoTrindade
force-pushed
the
bootsnap_fix
branch
from
50c3f39 to
a4d242c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in keyword arguments for Ruby 3.0 I believe the bootsnap integration stopped working.
This PR updates the
Bootsnap.setupmethod call to use**operator and get around the initialization issue.Since dry-system requires ruby 3.0 or higher I've updated the condition to check if bootsnap was available.
Also uncommented a test for bootsnap. I've added an empty file to get the test working but I'm open to other suggestions
Stacktrace from an example repo I created to show the issue
https://github.com/RicardoTrindade/Bootsnap-example