feat: adds typecheck scripts

dsanbr · Dec 24, 2022 · e079da5 · e079da5
1 parent 72a31fb
commit e079da5
Show file tree

Hide file tree

Showing 9 changed files with 74 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,6 +28,7 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install --prefer-offline --frozen-lockfile
       - run: pnpm nx-cloud start-ci-run
+      - run: pnpm nx affected --target=typecheck --parallel --max-parallel=3
       - run: pnpm nx affected --target=build --parallel --max-parallel=3
       - run: pnpm nx affected --target=test --parallel --max-parallel=2
       - run: pnpm nx-cloud stop-all-agents
@@ -50,6 +51,7 @@ jobs:
           cache: 'pnpm'
       - run: pnpm install
       - run: pnpm nx-cloud start-ci-run
+      - run: pnpm nx affected --target=typecheck --parallel --max-parallel=3
       - run: pnpm nx affected --target=build --parallel --max-parallel=3
       - run: pnpm nx affected --target=test --parallel --max-parallel=2
       - run: pnpm nx-cloud stop-all-agents

diff --git a/.gitignore b/.gitignore
@@ -57,4 +57,6 @@ storybook-static
 # Playwright
 **/test-results
 **/playwright-report
-**/playwright/.cache
+**/playwright/.cache
+
+*.tsbuildinfo
diff --git a/apps/client-e2e/project.json b/apps/client-e2e/project.json
@@ -17,14 +17,15 @@
         }
       }
     },
-    "ts-check": {
-      "executor": "@nrwl/workspace:run-commands",
+    "typecheck": {
+      "executor": "nx:run-commands",
       "options": {
         "commands": [
           {
-            "command": "tsc --build --force --verbose apps/client-e2e/tsconfig.json"
+            "command": "pnpm tsc --project apps/client-e2e/tsconfig.e2e.json --noEmit"
           }
-        ]
+        ],
+        "parallel": true
       }
     },
     "lint": {

diff --git a/apps/client/project.json b/apps/client/project.json
@@ -54,6 +54,20 @@
       "options": {
         "lintFilePatterns": ["apps/client/**/*.{ts,tsx,js,jsx}"]
       }
+    },
+    "typecheck": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "pnpm tsc --project apps/client/tsconfig.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project apps/client/tsconfig.spec.json --noEmit"
+          }
+        ],
+        "parallel": true
+      }
     }
   },
   "tags": []

diff --git a/libs/editor/project.json b/libs/editor/project.json
@@ -49,6 +49,23 @@
           "quiet": true
         }
       }
+    },
+    "typecheck": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "pnpm tsc --project libs/editor/tsconfig.lib.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project libs/editor/tsconfig.spec.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project libs/editor/.storybook/tsconfig.json --noEmit"
+          }
+        ],
+        "parallel": true
+      }
     }
   }
 }
diff --git a/libs/server/project.json b/libs/server/project.json
@@ -18,6 +18,20 @@
         "jestConfig": "libs/server/jest.config.ts",
         "passWithNoTests": true
       }
+    },
+    "typecheck": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "pnpm tsc --project libs/server/tsconfig.lib.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project libs/server/tsconfig.spec.json --noEmit"
+          }
+        ],
+        "parallel": true
+      }
     }
   }
 }
diff --git a/libs/ui/project.json b/libs/ui/project.json
@@ -70,6 +70,23 @@
           "quiet": true
         }
       }
+    },
+    "typecheck": {
+      "executor": "nx:run-commands",
+      "options": {
+        "commands": [
+          {
+            "command": "pnpm tsc --project libs/ui/tsconfig.lib.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project libs/ui/tsconfig.spec.json --noEmit"
+          },
+          {
+            "command": "pnpm tsc --project libs/ui/.storybook/tsconfig.json --noEmit"
+          }
+        ],
+        "parallel": true
+      }
     }
   }
 }
diff --git a/libs/ui/src/organisms/Sidebar/Sidebar.stories.tsx b/libs/ui/src/organisms/Sidebar/Sidebar.stories.tsx
@@ -6,7 +6,6 @@ import { Sidebar } from './Sidebar';
 const args: ComponentProps<typeof Sidebar> = {
   user: {
     name: 'Ahmed Elsakaan',
-    course: 'Computer Science',
     avatar: 'https://avatars.githubusercontent.com/u/20271968?v=4',
   },
   links: [

diff --git a/nx.json b/nx.json
@@ -23,7 +23,8 @@
           "lint",
           "test",
           "e2e",
-          "build-storybook"
+          "build-storybook",
+          "typecheck"
         ],
         "accessToken": "NDNkZmU5MzctMGIzNC00MTRjLWIyODUtYTE1NTRkYzE2ZDIwfHJlYWQtd3JpdGU="
       }