-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exozodi fix #402
Open
CoreySpohn
wants to merge
27
commits into
master
Choose a base branch
from
exozodi_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Exozodi fix #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Vband keyword to get_spectral_template
…ions, now applies fbeta after caching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Overhaul of the exozodiacal light modeling to correctly calculate the color factor, update for observations, and use proper equations.
TL.JEZ0
dictionary attribute. Structured similar to star_fluxes, it is keyed by the mode hex values and contains the exozodi intensity values for each star in the observing mode, withSU.scale_JEZ(sInd, mode)
method. This should be invoked afterSU.propag_system
is called. It gets theJEZ0
value for the mode/star and scales bySU.nEZ/SU.d**2
to turn the star'sJEZ0
value into a per-planet value at the current epoch.commonSystemnEZ
as an input for SU (defaults to True)SU.nEZ
array attribute which holds the number of exozodi for each planet in the simulationnEZ
as a planet attribute (instead offEZ
) for loading/dumpingSU.nEZ
is defined inSU.gen_physical_properties()
using the existingZL.gen_systemnEZ(nStars)
methodfEZ
as an output fromdump_system_params
as the current treatment of it is mode-dependent.SS.observation_detection
theself.calc_signal_noise
is given the JEZ values for each epochSS.observation_detection
andobservation_characterization
now returnJEZ
, previously thefEZ
was included in thesystemParamss
dict created bySU.dump_system_param
.JEZ
being mode dependent means that it shouldn't be treated as a "system parameter" in the same way that dMag, WA, distance, etc are.det_JEZ
instead ofdet_fEZ
..venv
to gitignoreType of change
All of the above
Reference any relevant issues (don't forget the #)
#374 and might also address #183 although it isn't directly an input
Checklist before requesting a review
e2eTests
and added new test scripts, as needed