Fixing confusing error message in TensorBoard plugin.

PiperOrigin-RevId: 330976779
dsnoor · Sep 10, 2020 · 752b1ef · 752b1ef
1 parent 2494b4d
commit 752b1ef
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 27 deletions.
diff --git a/...ness/frontend/fairness-tensorboard-container/fairness-tensorboard-container-template.html b/...ness/frontend/fairness-tensorboard-container/fairness-tensorboard-container-template.html
@@ -46,32 +46,47 @@
 
   <template is="dom-if" if="[[!slicingMetrics_.length]]">
     <div class="no-data-warning">
-      <h3>No fairness evaluation data was found.</h3>
-      <p>Probable causes:</p>
-      <ul>
-        <li>You haven’t written any evaluation data to your event files.</li>
-        <li>Tensorboard might be looking for your event files, please wait for few seconds.</li>
-        <li>TensorBoard can’t find your event files.</li>
-        <li>Selected evaluation run doesn't contain any fairness evaluation related data.</li>
-      </ul>
+      <template is="dom-if" if="[[!hideSelectEvalRunDropDown_]]">
+        <h3>No fairness evaluation data was found.</h3>
+        <p>Probable causes:</p>
+        <ul>
+          <li>You haven’t written any evaluation data to your event files.</li>
+          <li>Tensorboard might be looking for your event files, please wait for few seconds.</li>
+          <li>TensorBoard can’t find your event files.</li>
+          <li>Selected evaluation run doesn't contain any fairness evaluation related data.</li>
+        </ul>
 
-      <p>
-        If you’re new to using TensorBoard, and want to find out how to
-        add data and set up your event files, check out the Fairness Indicators
-        for Tensorboard
-        <a href="https://www.tensorflow.org/tensorboard/fairness_indicators" target="_blank" >
-          tutorial
-        </a>
-        and Fairness Indicators
-        <a href="https://github.com/tensorflow/fairness-indicators" target="_blank">README</a>.
-      </p>
+        <p>
+          If you’re new to using TensorBoard, and want to find out how to
+          add data and set up your event files, check out the Fairness Indicators
+          for Tensorboard
+          <a href="https://www.tensorflow.org/tensorboard/fairness_indicators" target="_blank" >
+            tutorial
+          </a>
+          and Fairness Indicators
+          <a href="https://github.com/tensorflow/fairness-indicators" target="_blank">README</a>.
+        </p>
 
-      <p>
-        If you think TensorBoard is configured properly, please see the section of the
-        <a href="https://github.com/tensorflow/tensorboard/blob/master/README.md#my-tensorboard-isnt-showing-any-data-whats-wrong"
-           target="_blank">README</a>
-        devoted to missing data problems and consider filing an issue on GitHub.
-      </p>
+        <p>
+          If you think TensorBoard is configured properly, please see the section of the
+          <a href="https://github.com/tensorflow/tensorboard/blob/master/README.md#my-tensorboard-isnt-showing-any-data-whats-wrong"
+             target="_blank">README</a>
+          devoted to missing data problems and consider filing an issue on
+          <a href="https://github.com/tensorflow/fairness-indicators/issues"
+             target="_blank">GitHub</a>.
+        </p>
+      </template>
+
+      <template is="dom-if" if="[[hideSelectEvalRunDropDown_]]">
+        <h3>Rendering Fairness Evaluation Results.</h3>
+        <p>
+          Note: This may take a couple of minutes. If the UI still fails to render, please check if
+          the evaluation output path provided in the URL contains the evaluation results, or
+          consider filing an issue on
+          <a href="https://github.com/tensorflow/fairness-indicators/issues"
+             target="_blank">GitHub</a>.
+        </p>
+      </template>
     </div>
   </template>
 </div>

diff --git a/...addons/fairness/frontend/fairness-tensorboard-container/fairness-tensorboard-container.js b/...addons/fairness/frontend/fairness-tensorboard-container/fairness-tensorboard-container.js
@@ -95,7 +95,8 @@ export class FairnessTensorboardContainer extends SelectEventMixin
        */
       hideSelectEvalRunDropDown_: {
         type: Boolean,
-        computed: 'computeHideSelectEvalRunDropDown_(evaluationOutputPath_)'
+        computed: 'computeHideSelectEvalRunDropDown_(evaluationOutputPath_)',
+        value: false
       },
 
       /**

diff --git a/tensorflow_model_analysis/static/vulcanized_tfma.js b/tensorflow_model_analysis/static/vulcanized_tfma.js