Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Many docs improvements #2171

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

peterschmidt85
Copy link
Contributor

Fixes #2170

@peterschmidt85 peterschmidt85 linked an issue Dec 31, 2024 that may be closed by this pull request
7 tasks
@@ -61,7 +61,7 @@ To use `dstack` with your own cloud accounts, create the `~/.dstack/server/confi
[configure backends](../reference/server/config.yml.md).
The server loads this file on startup.

Alternatively, you can configure backends on the [project settings page](../concepts/projects/#project-backends) via the control plane's UI.
Alternatively, you can configure backends on the [project settings page](../guides/projects/#project-backends) via the control plane's UI.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid link.

Suggested change
Alternatively, you can configure backends on the [project settings page](../guides/projects/#project-backends) via the control plane's UI.
Alternatively, you can configure backends on the [project settings page](administration.md#project-backends) via the control plane's UI.

Btw, I'd expect mkdocs to fail on an invalid link. This should be revisited in #1603

| `DSTACK_NODE_RANK` | The rank of the node |
| `DSTACK_MASTER_NODE_IP` | The internal IP address the master node |
| `DSTACK_NODES_IPS` | The list of internal IP addresses of all nodes delimited by "\n" |
??? info "System environment variables"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a #system-environment-variables anchor on line 345 that does not work anymore because of this change

@@ -267,77 +336,3 @@ environment, and its contents will persist across runs.
attach volumes to `/workflow` or any of its subdirectories.

The `dev-environment` configuration type supports many other options. See below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below.

This is the last line of the document now, there is nothing below.

Same in task.md and service.md

eos_token: "</s>"
```

##### Limitations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limitations is now part of the ToC because of toc_depth: 5.

Screenshot From 2025-01-03 13-41-26

I don't think it's supposed to be there, especially considering that clicking it doesn't work unless the TGI tab is open.

@@ -1187,36 +276,127 @@ See the [reference table](#default-permissions) for all configurable permissions
cat my-service-account-file.json | jq -c | jq -R
```

## `projects[n].backends[type=kubernetes].networking` { #_networking data-toc-label="networking" }
###### `projects[n].backends[type=kubernetes].networking` { #kuberentes-networking data-toc-label="networking" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo leads to an invalid anchor link.

Suggested change
###### `projects[n].backends[type=kubernetes].networking` { #kuberentes-networking data-toc-label="networking" }
###### `projects[n].backends[type=kubernetes].networking` { #kubernetes-networking data-toc-label="networking" }

Comment on lines +317 to +318
> The `dstack` server allows you to configure backends for multiple projects.
> If you don't need multiple projects, use only the `main` project.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) This note looks out of place here. Consider moving to the top of the reference or removing.

`dstack` can provision and manage compute across a variety of providers.

To use `dstack` with specific providers, configure backends in the
`~/.dstack/server/config.yml` file before starting the server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Consider linking this page to the reference, e.g. here.

Suggested change
`~/.dstack/server/config.yml` file before starting the server.
[`~/.dstack/server/config.yml`](../reference/server/config.yml.md) file before starting the server.

@peterschmidt85 peterschmidt85 requested a review from jvstme January 4, 2025 20:54
@peterschmidt85
Copy link
Contributor Author

@jvstme Pushed more changes to ensure concepts pages include all important examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Many docs improvements
2 participants