Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix volume attachment with dstack backend #2175

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix volume attachment with dstack backend #2175

wants to merge 1 commit into from

Conversation

un-def
Copy link
Collaborator

@un-def un-def commented Jan 3, 2025

Fixes: #2172
See: #1681
See: #1682

@un-def un-def requested a review from jvstme January 3, 2025 16:03
jvstme
jvstme approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@jvstme jvstme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the same change needed in get_job_mount_point_volume? Otherwise, I think, the volumes will be attached to the instance but not mounted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvstme jvstme jvstme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot attach an AWS volume on dstack Sky
2 participants
@un-def @jvstme