Add geography extension #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Maxxen! |
|
The error seems to be : I believe this build is passing on duckdb-geography CI ( https://github.com/paleolimbot/duckdb-geography ), but let me know if something is misconfigured on my end! |
|
Hi @paleolimbot, I see the issue— This happened because the I've opened a PR to fix this: #304. Cheers, |
carlopi
reviewed
Feb 21, 2025
|
@paleolimbot: I will come back on your repo vs wasm builds, removing them also had the nice side-effect of retriggering CI. @rustyconover: thanks for the fix, windows build is now going further, great! |
carlopi
approved these changes
Feb 21, 2025
|
Thanks and welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been working on a 'geography' extension to complement 'spatial' for data on the sphere. I think it's ready for community extension status, but let me know if there are missing components here that need to be handled!