Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create NFT Ronin Transfers #7136

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Create NFT Ronin Transfers #7136

merged 7 commits into from
Dec 12, 2024

Conversation

peterrliem
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]

quick links for more information:

@jeff-dude
Copy link
Member

at first glance, code looks good. however, the tests are failing on unique key errors for one row. can you run dbt compile locally, grab output query in target folder and run on dune app with a group by on unique keys having count > 1? that should return the one row, then you can dig into that row in separate query to see why it's failing

@jeff-dude jeff-dude self-assigned this Nov 18, 2024
@jeff-dude jeff-dude added WIP work in progress in review Assignee is currently reviewing the PR dbt: nft covers the NFT dbt subproject labels Nov 18, 2024
@peterrliem
Copy link
Contributor Author

@jeff-dude checks have passed. can we merge this? 🙏🏻

jeff-dude
jeff-dude approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, wonder what happened previously with no code changes to make run fine 🤔

@jeff-dude jeff-dude added ready-for-merging and removed WIP work in progress in review Assignee is currently reviewing the PR labels Dec 12, 2024
@jeff-dude jeff-dude merged commit 5ea5c4c into duneanalytics:main Dec 12, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeff-dude jeff-dude jeff-dude approved these changes

Assignees

@jeff-dude jeff-dude

Labels
dbt: nft covers the NFT dbt subproject ready-for-merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterrliem @jeff-dude @0xRobin