Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add banana gun evm bot trades spellbook #7180

Conversation

whalehunting
Copy link
Contributor

@whalehunting whalehunting commented Nov 24, 2024

This PR reimplements #6290 and aims to add the first EVM bot trades spellbook.

Description:

EVM bot trades data is growing, so it seems like a reasonable time to move them to Spellbook. I'm planning to do this for most EVM bots, so this spellbook should act as a blueprint for other bots.

Adds 3 new spellbooks:

  • banana_gun_ethereum_bot_trades
  • banana_gun_base_bot_trades
  • dex_evm_bot_trades

@whalehunting whalehunting marked this pull request as ready for review November 24, 2024 12:24
@0xRobin 0xRobin self-assigned this Nov 25, 2024
@0xRobin 0xRobin added WIP work in progress dbt: dex covers the DEX dbt subproject labels Nov 25, 2024
@0xRobin
Copy link
Collaborator

0xRobin commented Nov 25, 2024

@whalehunting Fixed the seed for you.
I did describe test_schema.git_dunesql_37fe81f_banana_gun_ethereum_trades_seed on Dune to see the actual schema and then added all the varbinary columns to the seed schema file. (The engine does not infer the varbinary type automatically, so they need to be specified)

@whalehunting whalehunting requested a review from 0xRobin November 25, 2024 09:32
@0xRobin 0xRobin added ready-for-merging and removed WIP work in progress labels Nov 25, 2024
@0xRobin 0xRobin merged commit bcb133e into duneanalytics:main Nov 28, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants