Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "zereox - v2 macro replacements 2 (#7168)" #7233

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

jeff-dude
Copy link
Member

This reverts commit e025533.

fyi @RantumBits :(

sadly it looks like the latest code has some bugs. our automated test for inflated amount_usd values on dex_aggregator.trades had 40k+ failed rows where > $1B per trade

if i run this:

select
    *
from
    dex_aggregator.trades
where
    amount_usd >= 1000000000
    and tx_hash = 0x0864937d2303a773e27fbc3a86fbd31b24d539b7e0200dc79a0f9f1e26f84f1b
    and evt_index = 249
limit
    1000

i'm seeing this output (i will be refreshing old data, so by the time you look, may be fixed):
image

if i look at that tx / evt_index in the logs, i see two different tokens being swapped then what the data above shows which would make sense for why amount_usd is calculating incorrectly:
https://etherscan.io/tx/0x0864937d2303a773e27fbc3a86fbd31b24d539b7e0200dc79a0f9f1e26f84f1b#eventlog#249

we will need to get this back in dev phase and use CI to ensure proper values are being written per swap.

@jeff-dude jeff-dude added hotfix dbt: dex covers the DEX dbt subproject labels Dec 3, 2024
@jeff-dude jeff-dude marked this pull request as ready for review December 3, 2024 20:48
@jeff-dude jeff-dude merged commit 588ca27 into main Dec 3, 2024
1 of 2 checks passed
@jeff-dude jeff-dude deleted the revert-0x branch December 3, 2024 20:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant