Revert "zereox - v2 macro replacements 2 (#7168)" #7233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e025533.
fyi @RantumBits :(
sadly it looks like the latest code has some bugs. our automated test for inflated
amount_usd
values ondex_aggregator.trades
had 40k+ failed rows where > $1B per tradeif i run this:
i'm seeing this output (i will be refreshing old data, so by the time you look, may be fixed):
if i look at that tx / evt_index in the logs, i see two different tokens being swapped then what the data above shows which would make sense for why
amount_usd
is calculating incorrectly:https://etherscan.io/tx/0x0864937d2303a773e27fbc3a86fbd31b24d539b7e0200dc79a0f9f1e26f84f1b#eventlog#249
we will need to get this back in dev phase and use CI to ensure proper values are being written per swap.