feat: add wstETH to trusted tokens #7312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hosuke
approved these changes
Dec 12, 2024
jeff-dude
approved these changes
Dec 12, 2024
Comment on lines
+198
to
+202
| data_tests: | ||
| - dbt_utils.unique_combination_of_columns: | ||
| combination_of_columns: | ||
| - blockchain | ||
| - contract_address |
There was a problem hiding this comment.
good catch, didn't even realize we were missing this
0xRobin
approved these changes
Dec 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
wstETH (Wrapped liquid staked Ether) by Lido has a market cap of over 16 billion (ref 1). It is commonly used as a quote token on Curve, particularly in pools involving LSTs or LRTs.
Enabling wstETH to be included as a trusted token would facilitate the development of price feeds for tokens currently only
available on Curve, such as ynETH
References:
quick links for more information: