Skip to content

Commit

Permalink
refactor(editor): Remove tracking for SAML test success (no-changelog) (
Browse files Browse the repository at this point in the history
n8n-io#8108)

Follow-up to: n8n-io#8102

It turns out that SAML test success cannot be tracked on the FE. We
might track on the BE, but after further discussion with Product, we do
not really need to track this property, so this PR simply removes it.
  • Loading branch information
ivov authored Dec 20, 2023
1 parent 97aa38e commit d917dfe
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions packages/editor-ui/src/views/SettingsSso.vue
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,6 @@ const getSamlConfig = async () => {
ssoSettingsSaved.value = !!config?.metadata;
};
let testSucceeded = false;
const onSave = async () => {
try {
const config =
Expand All @@ -110,7 +108,6 @@ const onSave = async () => {
telemetry.track('User updated single sign on settings', {
instance_id: rootStore.instanceId,
identity_provider: ipsType.value === 'url' ? 'metadata' : 'xml',
is_valid: testSucceeded,
is_active: ssoStore.isSamlLoginEnabled,
});
} catch (error) {
Expand All @@ -128,10 +125,8 @@ const onTest = async () => {
if (typeof window !== 'undefined') {
window.open(url, '_blank');
}
testSucceeded = true;
} catch (error) {
toast.showError(error, 'error');
testSucceeded = false;
}
};
Expand Down

0 comments on commit d917dfe

Please sign in to comment.