Minor API improvements #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 9, 2019 13:30
…uestFilter for common use cases.
droustchev
approved these changes
Jan 10, 2019
| // up to whomever made the request. | ||
| trait Upstream[-AddressingConfig] { | ||
| def metricsTag: String | ||
|
|
||
| def addressRequest(request: HttpRequest, addressingConfig: AddressingConfig): HttpRequest | ||
|
|
||
| def prepareRequestForDelivery(request: HttpRequest): HttpRequest = request | ||
| def requestFilter: RequestFilter[Unit] = NoOpRequestFilter |
There was a problem hiding this comment.
Should we not maintain the verb form here? So filterRequest and filterResponse? Makes the calls in the HttpProxy more readable in my opinion
--- upstream.requestFilter(addressedRequest, ())
+++ upstream.filterRequest(addressedRequest, ())There was a problem hiding this comment.
The verbs don't apply here, since calling the method does nothing but return the filter. It doesn't apply anything like previously.
In HttpProxy, there's apply implicitly called, it's upstream.requestFilter.apply(addressedRequest, ()).
There was a problem hiding this comment.
Ah ok, I did stumble across the signature here, but I didn't think of the implicit call to apply in the HttpProxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is probably best reviewed commit by commit. It's generally pretty self-explanatory.