Correct signatures of Aggregator methods for type safety #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
authData
passed to the various user-facingGenericAggregator
methods was useless - it was a non-specific type. This PR tweaks varies types and signatures to allow it to be specific. Now, implementors of theAggregator
class specify whichAuthData
type they expect to handle. If anAggregator
handling an incorrect type ofAuthData
(i.e. one that doesn't matchauthConfig.AuthData
) is passed toaggregatorRoute
and friends, a compilation error results.As a bonus, the signatures of the user-facing methods are much simpler.
Needs a version bump before merging.