Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream pruning fixes to v1.2.0 #1204

Merged
merged 46 commits into from
Nov 8, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Nov 7, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner November 7, 2024 10:49
@srene srene changed the base branch from main to release/v1.2.x November 7, 2024 10:50
@srene srene self-assigned this Nov 7, 2024
@srene srene linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 16.72727% with 458 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v1.2.x@34e29f6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...github.com/dymensionxyz/dymint/store/mock_Store.go 0.00% 301 Missing ⚠️
store/store.go 30.76% 27 Missing ⚠️
block/pruning.go 0.00% 22 Missing ⚠️
p2p/client.go 15.38% 22 Missing ⚠️
indexers/txindex/kv/kv.go 50.00% 17 Missing and 3 partials ⚠️
store/pruning.go 51.28% 12 Missing and 7 partials ⚠️
indexers/blockindexer/kv/kv.go 47.05% 16 Missing and 2 partials ⚠️
indexers/txindex/indexer_service.go 5.26% 18 Missing ⚠️
p2p/block_sync_dag.go 50.00% 4 Missing and 2 partials ⚠️
rpc/client/client.go 50.00% 2 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@                Coverage Diff                @@
##             release/v1.2.x    #1204   +/-   ##
=================================================
  Coverage                  ?   34.55%           
=================================================
  Files                     ?      135           
  Lines                     ?    22601           
  Branches                  ?        0           
=================================================
  Hits                      ?     7810           
  Misses                    ?    13671           
  Partials                  ?     1120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@srene srene closed this Nov 8, 2024
@omritoptix omritoptix reopened this Nov 8, 2024
@omritoptix omritoptix merged commit 484af6e into release/v1.2.x Nov 8, 2024
14 checks passed
@omritoptix omritoptix deleted the srene/upstream-pruning-fixes branch November 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible memory leak while pruning
2 participants