Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fork): get next revision start height from sl in validation #1298

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Dec 24, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

  • to avoid false positive state validation when multiple forks, because its not skipping next sequencer validation in the previous state update to a fork
    --

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #1297

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Dec 24, 2024
@srene srene requested a review from a team as a code owner December 24, 2024 16:14
@srene srene merged commit 7be9ddb into main Dec 24, 2024
5 checks passed
@srene srene deleted the srene/1297-sl-validate-fork-fix branch December 24, 2024 21:50
omritoptix pushed a commit that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants