Merge pull request sl1pm4t#69 from sl1pm4t/issue-50

Convert colons to underscores
ebostijancic · Jul 30, 2020 · 7e02b5c · 7e02b5c
2 parents 04277d7 + 13765f4
commit 7e02b5c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/pkg/tfkschema/name_mapper.go b/pkg/tfkschema/name_mapper.go
@@ -2,11 +2,12 @@ package tfkschema
 
 import (
 	"fmt"
-	"github.com/sl1pm4t/k2tf/pkg/k8sutils"
 	"os"
 	"reflect"
 	"strings"
 
+	"github.com/sl1pm4t/k2tf/pkg/k8sutils"
+
 	"github.com/jinzhu/inflection"
 	"k8s.io/apimachinery/pkg/runtime"
 
@@ -96,6 +97,9 @@ func NormalizeTerraformName(s string, toSingular bool, path string) string {
 	}
 	s = strcase.ToSnake(s)
 
+	// colons are not allowed by Terraform
+	s = strings.ReplaceAll(s, ":", "_")
+
 	return s
 }
 

diff --git a/pkg/tfkschema/name_mapper_test.go b/pkg/tfkschema/name_mapper_test.go
@@ -243,6 +243,15 @@ func Test_NormalizeTerraformName(t *testing.T) {
 			},
 			"capabilities",
 		},
+		{
+			"metallb-system:speaker",
+			args{
+				"metallb-system:speaker",
+				true,
+				"",
+			},
+			"metallb_system_speaker",
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {