frontend/pdf/print: set type to module in package.json #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
✅ Feature branch deployment ready!
|
BacLuc
force-pushed
the
frontend-switch-to-module
branch
from
ab85dfd to
56ef60d
Compare
BacLuc
changed the title
BacLuc
force-pushed
the
frontend-switch-to-module
branch
2 times, most recently
from
e7b9659 to
e932b28
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
force-pushed
the
frontend-switch-to-module
branch
from
e932b28 to
30f8c7d
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
For the changes in vue.config.js, see: |
And switch to esm syntax for the matchingTranslationKeys eslint plugin. Because there cannot be dashes in an identifier, the rule is now called 'matchingTranslationKeys'. jest-serializer-vue-tjw loads the vue config with require, and seems to expect a commonjs module. We switched to a esm module, and now the structure is not pluginOptions.jestSerializer, but default.pluginOptions.jestSerializer -> with the added export we can support vue itself and jest-serializer-vue-tjw. This might enable us to update vite-plugin-comlink - ecamp#6220 And might help with - ecamp#6038 Fix checked in dist files in pdf/dist/
BacLuc
force-pushed
the
frontend-switch-to-module
branch
from
30f8c7d to
b6142f4
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
pmattmann
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frontend/pdf/print: set type to module in package.json
And switch to esm syntax for the matchingTranslationKeys eslint plugin.
Because there cannot be dashes in an identifier, the rule is now called
'matchingTranslationKeys'.
jest-serializer-vue-tjw loads the vue config with require,
and seems to expect a commonjs module.
We switched to a esm module, and now the structure is not
pluginOptions.jestSerializer,
but
default.pluginOptions.jestSerializer
-> with the added export we can support vue itself and jest-serializer-vue-tjw.
This might enable us to update vite-plugin-comlink
And might help with
Fix checked in dist files in pdf/dist/
Open: