Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR on personal fork - API docs/CI dashboard #10

Closed
wants to merge 50 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
1229277
maybe fix the output file path of benchmark; make the GH pages copyin…
echeran Oct 7, 2020
aa5899c
maybe fix the output file path of benchmark; make the GH pages copyin…
echeran Oct 7, 2020
94b8a47
add debugging output for WF job dependencies on templated (matrix) jobs
echeran Oct 7, 2020
7a42d3c
create benchmark output dir
echeran Oct 7, 2020
0027e35
debug the current git branches in runner for the GH pages copying action
echeran Oct 7, 2020
c1428cb
checkout the repo during the GH pages action
echeran Oct 7, 2020
6119a90
more debugging of benchmark action
echeran Oct 7, 2020
19fe1de
trying again to have each benchmark work independently
echeran Oct 7, 2020
d0e5848
forgot to remove step in attempt to reconsolidate per-component GH ac…
echeran Oct 7, 2020
4edd63d
use testing (personal fork repo) GH deploy key; try GH pages push fr…
echeran Oct 7, 2020
efd3979
use gh-pages branch (?) to save commits
echeran Oct 7, 2020
8978bfe
testing-only changes to see if API docs get re-generated unaffected b…
echeran Oct 7, 2020
5ee1e54
move benchmark job to build-and-test workflow to potentially prevent …
echeran Oct 8, 2020
b20cff0
Revert "move benchmark job to build-and-test workflow to potentially …
echeran Oct 8, 2020
970a512
adds cache action for prev bench results; configures output data file…
echeran Oct 8, 2020
1a780b2
testing changes - changed GH pages target repo
echeran Oct 8, 2020
b00cd37
better test debugging
echeran Oct 8, 2020
8066160
fix benchmark action output dir; adjust cache root dir; remove parall…
echeran Oct 8, 2020
327ff61
fix cache dir path; add more debugging for GH pages action
echeran Oct 8, 2020
ea3f590
switch to gh-pages to fetch bench dash HTML output; add debugging
echeran Oct 8, 2020
9fd3ccd
testing-only changes to speed up testing; add another cache step for …
echeran Oct 8, 2020
f6067cc
fix debug step
echeran Oct 8, 2020
d0c0ff7
fixes debug steps
echeran Oct 8, 2020
ceeef64
get Rust docs output to share cache key with all GH pages output steps
echeran Oct 8, 2020
6441a7b
move benchmarking job to same WF as API docs job to hopefully avoid c…
echeran Oct 8, 2020
362cae9
fix debugging
echeran Oct 8, 2020
770677c
fix paths of dir to copy in API docs' GH pages action
echeran Oct 8, 2020
f4e7bcc
add debugging of API docs job
echeran Oct 8, 2020
aafbc4e
updates main README's links to dashboard URLs
echeran Oct 8, 2020
7e9af8b
fixes relative URL in redirect for root index.html to API docs root
echeran Oct 8, 2020
7aca112
updates README link to API docs
echeran Oct 8, 2020
e51dc98
replace caching with persisting
echeran Oct 8, 2020
f7cdeb3
fix typo
echeran Oct 8, 2020
70fbcc9
allow first time download to not fail (don't fail first instance)
echeran Oct 8, 2020
fc41c0b
remove caching; try upload/download across jobs within a workflow, ju…
echeran Oct 9, 2020
71ae8af
more debugging of upload/download details
echeran Oct 9, 2020
c30c272
fix upload files path
echeran Oct 9, 2020
b0ed8f7
defer GH pages uploading to during following API docs job (via upload…
echeran Oct 9, 2020
b46aa34
attempt to use local gh-pages branch to store historical benchmark data
echeran Oct 9, 2020
403b88a
attempt to use default GH token to enable auto-push of commit
echeran Oct 9, 2020
92c59d9
attempt to add parallel workflow that compares perf between PR & master
echeran Oct 9, 2020
f7619e7
configure versions for criterion comparison GH action
echeran Oct 9, 2020
bcdb3e5
fix typo
echeran Oct 9, 2020
87c5f8d
remove criterion comparison WF; attempt to re-enable benchmark commen…
echeran Oct 9, 2020
748d7ef
workflow file cleanup
echeran Oct 9, 2020
405e7e7
attempt to tease apart the pushing of the dashboard output file commi…
echeran Oct 9, 2020
b435462
fix typo in GH action usage of env var
echeran Oct 9, 2020
cb92bec
Revert "attempt to tease apart the pushing of the dashboard output fi…
echeran Oct 9, 2020
0a86d4b
duplicate the benchmark dashboard step to prevent storage of historic…
echeran Oct 9, 2020
7ae8f77
mock commit to trigger workflow
echeran Oct 9, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo in GH action usage of env var
  • Loading branch information
echeran committed Oct 9, 2020
commit b435462b086eeadd7a6dbfcfe373cac6ce019456
2 changes: 1 addition & 1 deletion .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ jobs:
# The branch notation in the `git push` command below should match the branch supplied in the benchmark action under `gh-pages-branch`.
# The push is from the PR's temporary speculative merge commit within the GH action's VM's checked-out repo working tree, and the destination is the main repo.
- name: Store dashboard output files commit in main repo (master branch only)
run: git push 'https://${{ GITHUB_ACTOR }}:${{ secrets.PERSONAL_GITHUB_TOKEN }}@github.com/unicode-org/icu4x.git' gh-pages:gh-pages
run: git push 'https://${{ env.GITHUB_ACTOR }}:${{ secrets.PERSONAL_GITHUB_TOKEN }}@github.com/unicode-org/icu4x.git' gh-pages:gh-pages


# if: github.event_name == 'push' && github.ref == 'refs/heads/master'
Expand Down