Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing PR to test GH Actions CI build failures for macOS builds #5

Closed
wants to merge 4 commits into from
Closed

Testing PR to test GH Actions CI build failures for macOS builds #5

wants to merge 4 commits into from

Conversation

echeran
Copy link
Owner

@echeran echeran commented Aug 18, 2020

Testing is part of the initial exploratory diagnosis work for unicode-org#201

echeran and others added 3 commits July 31, 2020 15:53
@echeran
Add link in Readme to API docs (Rust doc) (unicode-org#188)
9a296e8
@zbraniecki
Add PluralRules (unicode-org#119)
c4dc724 
* Add icu::pluralrules

* Apply reviewers feedback

* Second round of feedback

* Remove float to PluralOperands

* cargo fmt

* Improve PluralCategory variant docs
@filmil
Naming style (unicode-org#208)
333d83b 
* Adds style guilde to the documentation index

* Adds the naming style rule.

The intention of the naming style is to codify the conventions
that the ICU4X team prefers.

Issue: 183
@coveralls
Copy link

coveralls commented Aug 18, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build c1d6f7c238ab4fdc3aac9b4b9253b840f831e131-PR-5

  • 249 of 302 (82.45%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 89.293%
Changes Missing Coverage Covered Lines Changed/Added Lines %
components/pluralrules/src/lib.rs 3 7 42.86%
components/pluralrules/src/rules/lexer.rs 79 88 89.77%
components/pluralrules/src/operands.rs 42 56 75.0%
components/pluralrules/src/rules/ast.rs 9 35 25.71%
Totals Coverage Status
Change from base Build d2ba9b3eb7a7750d2dc7df5b5d62428b0bed61d0: -1.5%
Covered Lines: 1401
Relevant Lines: 1569
💛 - Coveralls

@echeran echeran changed the title Testing PR to test GH Actions BI build failures for macOS builds Testing PR to test GH Actions CI build failures for macOS builds Aug 19, 2020
@echeran
Copy link
Owner Author

echeran commented Aug 19, 2020

master wasn't updated properly before creating PR so closing and recreating

@echeran echeran closed this Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@echeran @coveralls @zbraniecki @filmil