-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#571] Fix completion queue capacity exceeded when history > buffer #572
Merged
elfenpiff
merged 3 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-571-fix-history-bug
Jan 3, 2025
Merged
[#571] Fix completion queue capacity exceeded when history > buffer #572
elfenpiff
merged 3 commits into
eclipse-iceoryx:main
from
elfenpiff:iox2-571-fix-history-bug
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
+ Coverage 79.25% 79.27% +0.02%
==========================================
Files 203 203
Lines 25230 25235 +5
==========================================
+ Hits 19995 20006 +11
+ Misses 5235 5229 -6
|
elBoberido
previously approved these changes
Dec 30, 2024
elBoberido
reviewed
Dec 30, 2024
elBoberido
previously approved these changes
Jan 2, 2025
elfenpiff
force-pushed
the
iox2-571-fix-history-bug
branch
2 times, most recently
from
January 2, 2025 13:52
082b4f4
to
4c7b569
Compare
elfenpiff
force-pushed
the
iox2-571-fix-history-bug
branch
from
January 2, 2025 14:52
4c7b569
to
f5fa861
Compare
elBoberido
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewer
When the subscriber reduces its buffer size so that it is smaller than the history size of the service and then, while the publisher is delivering the history, consumes and releases all samples in the history, the completion queue capacity will be exceeded.
This can be fixed by checking for samples in the completion queue on the publisher side after each history sample was delivered.
Pre-Review Checklist for the PR Author
Convert to draft
)SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #571