Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#571] Fix completion queue capacity exceeded when history > buffer #572

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 30, 2024

Notes for Reviewer

When the subscriber reduces its buffer size so that it is smaller than the history size of the service and then, while the publisher is delivering the history, consumes and releases all samples in the history, the completion queue capacity will be exceeded.
This can be fixed by checking for samples in the completion queue on the publisher side after each history sample was delivered.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #571

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.27%. Comparing base (f4931fd) to head (f5fa861).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/port/publisher.rs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   79.25%   79.27%   +0.02%     
==========================================
  Files         203      203              
  Lines       25230    25235       +5     
==========================================
+ Hits        19995    20006      +11     
+ Misses       5235     5229       -6     
Files with missing lines Coverage Δ
iceoryx2/src/config.rs 77.77% <100.00%> (ø)
iceoryx2/src/port/update_connections.rs 33.33% <ø> (ø)
...yx2/src/service/static_config/messaging_pattern.rs 92.30% <100.00%> (ø)
iceoryx2/src/port/publisher.rs 85.41% <87.50%> (-0.05%) ⬇️

... and 8 files with indirect coverage changes

elBoberido
elBoberido previously approved these changes Dec 30, 2024
elBoberido
elBoberido previously approved these changes Jan 2, 2025
iceoryx2/src/port/publisher.rs Show resolved Hide resolved
iceoryx2/src/port/publisher.rs Show resolved Hide resolved
@elfenpiff elfenpiff force-pushed the iox2-571-fix-history-bug branch 2 times, most recently from 082b4f4 to 4c7b569 Compare January 2, 2025 13:52
@elfenpiff elfenpiff force-pushed the iox2-571-fix-history-bug branch from 4c7b569 to f5fa861 Compare January 2, 2025 14:52
@elfenpiff elfenpiff merged commit 7dbabc1 into eclipse-iceoryx:main Jan 3, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants