Skip to content

Commit

Permalink
update PR template API change item
Browse files Browse the repository at this point in the history
Updated the API change item in the PR checklist to link towards the
runbook for changing the Firecracker API.

Signed-off-by: George Pisaltu <[email protected]>
  • Loading branch information
georgepisaltu authored and dianpopa committed Nov 5, 2021
1 parent 096fff3 commit 7e7d977
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Fixes #

`[Author TODO: add description of changes.]`

- [ ] This functionality can be added in [`rust-vmm`](https://github.com/rust-vmm).
- [ ] This functionality can be added in [`rust-vmm`][1].

## License Acceptance

Expand All @@ -27,6 +27,9 @@ the terms of the Apache 2.0 license.
- [ ] The description of changes is clear and encompassing.
- [ ] Any required documentation changes (code and docs) are included in this PR.
- [ ] Any newly added `unsafe` code is properly documented.
- [ ] Any API changes are reflected in `firecracker/swagger.yaml`.
- [ ] Any API changes follow the [Runbook for Firecracker API changes][2].
- [ ] Any user-facing changes are mentioned in `CHANGELOG.md`.
- [ ] All added/changed functionality is tested.

[1]: https://github.com/rust-vmm
[2]: ../docs/api-change-runbook.md

0 comments on commit 7e7d977

Please sign in to comment.