refactor(pfcp): Improve logging and error handling during session create/modify/delete #592
+63
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirog-spb
reviewed
Feb 8, 2025
cmd/core/pdr.go
Outdated
| if spdrInfo.Ipv4 != nil { | ||
| if err := mapOperations.PutPdrDownlink(spdrInfo.Ipv4, spdrInfo.PdrInfo); err != nil { | ||
| log.Info().Msgf("Can't apply IPv4 PDR: %s", err.Error()) | ||
| log.Error().Msgf("Can't apply IPv4 PDR: %s", err.Error()) |
There was a problem hiding this comment.
It would be nice to use zerolog feature to trace errors:
log.Error().Err(err).Msg("Can't apply IPv4 PDR")
pirog-spb
changed the title
pespin
force-pushed
the
pespin/pr-log
branch
2 times, most recently
from
55c7376 to
4bed3ab
Compare
…ate/modify/delete Before this patch, eupf would silently (info log level) skip PDR creation failures due to map sizes being too small, accepting the the PFCP session creation request. This patch makes sure: * The issue is reported at a meaningful log level (warn or error) * The PFCP session creation request is rejectedt
pespin
force-pushed
the
pespin/pr-log
branch
from
4bed3ab to
710763a
Compare
|
@pirog-spb Let me know if this one is fine now too and can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, eupf would silently (info log level) skip PDR creation failures due to map sizes being too small, accepting the the PFCP session creation request.
This patch makes sure: