Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand functionality of ISystemProvider #87

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Conversation

dnwpark
Copy link
Contributor

@dnwpark dnwpark commented Jan 22, 2025

The ISystemProvider is used when setting up a connection.

This PR expands its functionality so that:

  • all access to files, directories, environment variables, operating system, etc. are done via the ISystemProvider.
  • EdgeDBConnection parsing functions have an internal implementation which can take a custom ISystemProvider
    • This internal implementation is used by tests.

@dnwpark dnwpark requested a review from mmastrac January 22, 2025 00:56
Copy link

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnwpark dnwpark merged commit 2a26012 into connection-timeout Jan 29, 2025
2 checks passed
@dnwpark dnwpark deleted the system-provider branch January 29, 2025 15:20
@dnwpark dnwpark restored the system-provider branch January 29, 2025 15:23
@dnwpark dnwpark deleted the system-provider branch January 29, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants