This repository has been archived by the owner on Oct 3, 2018. It is now read-only.
only remove pid if parent process is 1 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -94,4 +94,5 @@ def run(app, pidfile, logfile, name=None, no_daemon=False, uid=None, | |||
| try: | |||
| arbiter.run() | |||
| finally: | |||
| remove_pidfile(pidfile) | |||
| if os.getppid() is 1: | |||
There was a problem hiding this comment.
do we know if this is this a somewhat accepted way of determining whether a process is the parent? also, does it make sense to you to need that check here, or does the whole mechanism seem weird?
|
If this has been verified to fix the problem described in the mantis, I say we merge it. 🚒 |
karlbohlmark
added a commit
that referenced
this pull request
Nov 12, 2013
only remove pid if parent process is 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.