Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue736 unit testing w prop files take2 #742

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

eeverman
Copy link
Owner

@eeverman eeverman commented Oct 28, 2022

All Submissions:

Thank you! Please check that...

  • You branched from the main branch and the pull request is to the main branch
  • Your code is up to date with the latest code from main
  • You followed the guidelines in the Contributing Guide?
  • Your code does not decrease test coverage of existing code, and is near 100% for new code
  • If this is related to an issue, please include a link to the issue with the 'Fixes #XXX' syntax.

Fixes #736

@eeverman eeverman changed the base branch from homepage to main October 29, 2022 02:11
@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 89.53% // Head: 89.28% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (7491bac) compared to base (9b8879a).
Patch coverage: 85.43% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #742      +/-   ##
============================================
- Coverage     89.53%   89.28%   -0.25%     
- Complexity     1230     1294      +64     
============================================
  Files           136      142       +6     
  Lines          3661     3856     +195     
  Branches        434      450      +16     
============================================
+ Hits           3278     3443     +165     
- Misses          273      292      +19     
- Partials        110      121      +11     
Impacted Files Coverage Δ
...g/yarnandtail/andhow/testutil/AndHowTestUtils.java 95.74% <0.00%> (-4.26%) ⬇️
...g/yarnandtail/andhow/junit5/ext/ExtensionUtil.java 68.18% <68.18%> (ø)
...ow/junit5/ext/ConfigFromFileBeforeThisTestExt.java 80.00% <80.00%> (ø)
...dtail/andhow/junit5/ext/ConfigFromFileBaseExt.java 84.12% <84.12%> (ø)
...g/yarnandtail/andhow/junit5/ext/ExtensionType.java 95.23% <95.23%> (ø)
...dhow/junit5/ext/EnableJndiForThisTestClassExt.java 100.00% <100.00%> (ø)
...how/junit5/ext/EnableJndiForThisTestMethodExt.java 100.00% <100.00%> (ø)
...g/yarnandtail/andhow/junit5/ext/ExtensionBase.java 100.00% <100.00%> (ø)
...ow/junit5/ext/RestoreSysPropsAfterEachTestExt.java 100.00% <100.00%> (ø)
...ow/junit5/ext/RestoreSysPropsAfterThisTestExt.java 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify unit testing w/ different property values
2 participants