feat: remove tracer (#311)

eggjs · Feb 3, 2017 · 0c38b9b · 0c38b9b
1 parent 8d98e4f
commit 0c38b9b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 43 deletions.
diff --git a/app/extend/context.js b/app/extend/context.js
@@ -76,16 +76,6 @@ const proto = module.exports = {
     return this[HELPER];
   },
 
-  /**
-   * 默认返回一个空对象，需要实现这个接口
-   *
-   * 插件需要实现一个内部约定 getter: `_tracer`
-   * @member {Object} Context#tracer
-   */
-  get tracer() {
-    return this._tracer || {};
-  },
-
   /**
    * Wrap app.loggers with context infomation,
    * if a custom logger is defined by naming aLogger, then you can `ctx.getLogger('aLogger')`

diff --git a/test/app/extend/context.test.js b/test/app/extend/context.test.js
@@ -54,9 +54,6 @@ describe('test/app/extend/context.test.js', () => {
 
       app.mockContext({
         userId: '123123',
-        tracer: {
-          traceId: '456456',
-        },
       });
 
       yield request(app.callback())
@@ -68,7 +65,7 @@ describe('test/app/extend/context.test.js', () => {
       const errorContent = fs.readFileSync(path.join(logdir, 'common-error.log'), 'utf8');
       errorContent.should.containEql('nodejs.Error: error foo');
       errorContent.should.containEql('nodejs.Error: core error foo');
-      errorContent.should.match(/\[123123\/[\d.]+\/456456\/\d+ms GET \/logger\?message=foo]/);
+      errorContent.should.match(/\[123123\/[\d.]+\/-\/\d+ms GET \/logger\?message=foo]/);
 
       const loggerContent = fs.readFileSync(path.join(logdir, 'demo-web.log'), 'utf8');
       loggerContent.should.not.containEql('debug foo');

diff --git a/test/fixtures/apps/middlewares/app/controller/trace.js b/test/fixtures/apps/middlewares/app/controller/trace.js
diff --git a/test/fixtures/apps/middlewares/app/router.js b/test/fixtures/apps/middlewares/app/router.js
@@ -2,8 +2,5 @@
 
 module.exports = app => {
   app.get('/', app.controller.home);
-  app.get('/traceClient', app.controller.trace.traceClient);
-
-  app.get('/traceServer', app.controller.trace.traceServer);
   app.get('/error', app.controller.error);
 };