Allow to ignore rows via None return value from CsvConverter.convert #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest 8.2.2 requires at least Python 3.8.
If the row in the input csv should produce no output in the output file the user can now return `None` for that row from their `CsvConverter.convert` method. closes egh#139
|
LGTM! Thanks for the upgrades. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to update some dependencies to get the project running on my machine, we can remove that commit if you don't want it.
I still had to run
pip3 uninstall pyto getpytestto run with Python 3.11, see pytest-dev/pytest#9181 (comment).This PR works on #139.