Use Handlerbars RunTime options over Eval handlers

egovernments · Mar 8, 2022 · b132d4e · himeshr-egov · Mar 8, 2022 · himeshr-egov
1 parent 4ad320a
commit b132d4e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/backend/certificate_api/src/services/configuration_service.js b/backend/certificate_api/src/services/configuration_service.js
@@ -123,7 +123,7 @@ class ConfigurationService {
     return certificateTemplate;
   }
   async addHelpers(key){
-    let helper = await loadConfigurationValues(key, async() => await configuration.AddHelpers(key));
+    let helper = await loadConfigurationValues(key, async() => await configuration.addHelpers(key));
     updateConfigValues(key,helper);
     return helper;
   }

diff --git a/backend/certificate_api/src/services/pdf_service.js b/backend/certificate_api/src/services/pdf_service.js
@@ -6,10 +6,11 @@ const configurationService = new ConfigurationService();
 
 async function createPDF(htmlData, data) {
   const template = Handlebars.compile(htmlData);
-  let helpers = Handlebars.compile(await configurationService.addHelpers(HELPERS.CERTIFICATE_HELPER_FUNCTIONS))().toString();
-  eval(helpers);
 
-  let certificate = template(data);
+  const handlers = Handlebars.compile(await configurationService.addHelpers(HELPERS.CERTIFICATE_HELPER_FUNCTIONS))();
+  const handlerObj = new Function('return '+handlers)();
+  let certificate = template(data, {helpers:handlerObj});
+
   const browser = await puppeteer.launch({
     headless: true,
     //comment to use default

diff --git a/default-configuration/etcd/certificateHelperFunctions.js b/default-configuration/etcd/certificateHelperFunctions.js
@@ -1,2 +1,4 @@
-Handlebars.registerHelper("loud", function (aString) { return aString.toString().toUpperCase() });
-Handlebars.registerHelper("small", function (aString) { return aString.toString().toLowerCase() });
+helper={
+    loud: function (aString) { return aString.toString().toUpperCase() },
+    small: function (aString) { return aString.toString().toLowerCase() }
+}