feat: setting background music to 60% for better tuning (flutter#424)

* feat: setting background music to 60% for better tuning * better code
eis6aer · May 9, 2022 · bab088f · bab088f
1 parent 37f35dc
commit bab088f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 8 deletions.
diff --git a/packages/pinball_audio/lib/src/pinball_audio.dart b/packages/pinball_audio/lib/src/pinball_audio.dart
@@ -59,7 +59,7 @@ typedef CreateAudioPool = Future<AudioPool> Function(
 typedef PlaySingleAudio = Future<void> Function(String);
 
 /// Defines the contract for looping a single audio.
-typedef LoopSingleAudio = Future<void> Function(String);
+typedef LoopSingleAudio = Future<void> Function(String, {double volume});
 
 /// Defines the contract for pre fetching an audio.
 typedef PreCacheSingleAudio = Future<void> Function(String);
@@ -101,18 +101,20 @@ class _LoopAudio extends _Audio {
     required this.preCacheSingleAudio,
     required this.loopSingleAudio,
     required this.path,
+    this.volume,
   });
 
   final PreCacheSingleAudio preCacheSingleAudio;
   final LoopSingleAudio loopSingleAudio;
   final String path;
+  final double? volume;
 
   @override
   Future<void> load() => preCacheSingleAudio(prefixFile(path));
 
   @override
   void play() {
-    loopSingleAudio(prefixFile(path));
+    loopSingleAudio(prefixFile(path), volume: volume ?? 1);
   }
 }
 
@@ -121,10 +123,12 @@ class _SingleLoopAudio extends _LoopAudio {
     required PreCacheSingleAudio preCacheSingleAudio,
     required LoopSingleAudio loopSingleAudio,
     required String path,
+    double? volume,
   }) : super(
           preCacheSingleAudio: preCacheSingleAudio,
           loopSingleAudio: loopSingleAudio,
           path: path,
+          volume: volume,
         );
 
   bool _playing = false;
@@ -296,6 +300,7 @@ class PinballAudioPlayer {
         preCacheSingleAudio: _preCacheSingleAudio,
         loopSingleAudio: _loopSingleAudio,
         path: Assets.music.background,
+        volume: .6,
       ),
     };
   }

diff --git a/packages/pinball_audio/test/src/pinball_audio_test.dart b/packages/pinball_audio/test/src/pinball_audio_test.dart
@@ -33,7 +33,7 @@ class _MockPlaySingleAudio extends Mock {
 }
 
 class _MockLoopSingleAudio extends Mock {
-  Future<void> onCall(String url);
+  Future<void> onCall(String url, {double volume});
 }
 
 abstract class _PreCacheSingleAudio {
@@ -77,7 +77,8 @@ void main() {
       when(() => playSingleAudio.onCall(any())).thenAnswer((_) async {});
 
       loopSingleAudio = _MockLoopSingleAudio();
-      when(() => loopSingleAudio.onCall(any())).thenAnswer((_) async {});
+      when(() => loopSingleAudio.onCall(any(), volume: any(named: 'volume')))
+          .thenAnswer((_) async {});
 
       preCacheSingleAudio = _MockPreCacheSingleAudio();
       when(() => preCacheSingleAudio.onCall(any())).thenAnswer((_) async {});
@@ -443,8 +444,10 @@ void main() {
         audioPlayer.play(PinballAudio.backgroundMusic);
 
         verify(
-          () => loopSingleAudio
-              .onCall('packages/pinball_audio/${Assets.music.background}'),
+          () => loopSingleAudio.onCall(
+            'packages/pinball_audio/${Assets.music.background}',
+            volume: .6,
+          ),
         ).called(1);
       });
 
@@ -455,8 +458,10 @@ void main() {
           ..play(PinballAudio.backgroundMusic);
 
         verify(
-          () => loopSingleAudio
-              .onCall('packages/pinball_audio/${Assets.music.background}'),
+          () => loopSingleAudio.onCall(
+            'packages/pinball_audio/${Assets.music.background}',
+            volume: .6,
+          ),
         ).called(1);
       });
     });