Fixed: Breaking change in tabs.onUpdated properties

ekmixon · Mar 25, 2021 · e471eee · e471eee
1 parent 72ab96e
commit e471eee
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 15 deletions.
diff --git a/addon/actions/tabs.js b/addon/actions/tabs.js
@@ -233,9 +233,17 @@ async function updateTabsTree() {
 function setupTabsListeners() {
   browser.tabs.onCreated.addListener(this.actions.onTabCreated)
   browser.tabs.onRemoved.addListener(this.actions.onTabRemoved)
-  browser.tabs.onUpdated.addListener(this.actions.onTabUpdated, {
-    properties: ['pinned', 'title', 'status'],
-  })
+  try {
+    // From v88 (https://bugzilla.mozilla.org/show_bug.cgi?id=1680279)
+    browser.tabs.onUpdated.addListener(this.actions.onTabUpdated, {
+      properties: ['pinned', 'title', 'status', 'url'],
+    })
+  } catch (err) {
+    // Before v88 (Remove after next ESR - v91)
+    browser.tabs.onUpdated.addListener(this.actions.onTabUpdated, {
+      properties: ['pinned', 'title', 'status'],
+    })
+  }
   browser.tabs.onActivated.addListener(this.actions.onTabActivated)
   browser.tabs.onMoved.addListener(this.actions.onTabMoved)
   browser.tabs.onAttached.addListener(this.actions.onTabAttached)

diff --git a/src/sidebar/handlers/tabs.js b/src/sidebar/handlers/tabs.js
@@ -821,18 +821,21 @@ function onTabActivated(info) {
  */
 function setupTabsListeners() {
   browser.tabs.onCreated.addListener(this.handlers.onTabCreated)
-  browser.tabs.onUpdated.addListener(this.handlers.onTabUpdated, {
-    properties: [
-      'audible',
-      'discarded',
-      'favIconUrl',
-      'hidden',
-      'mutedInfo',
-      'pinned',
-      'status',
-      'title',
-    ],
-  })
+  try {
+    // From v88 (https://bugzilla.mozilla.org/show_bug.cgi?id=1680279)
+    browser.tabs.onUpdated.addListener(this.handlers.onTabUpdated, {
+      // prettier-ignore
+      properties: ['audible','discarded','favIconUrl','hidden','mutedInfo','pinned','status',
+        'title','url'],
+    })
+  } catch (err) {
+    // Before v88 (Remove after next ESR - v91)
+    browser.tabs.onUpdated.addListener(this.handlers.onTabUpdated, {
+      // prettier-ignore
+      properties: ['audible','discarded','favIconUrl','hidden','mutedInfo','pinned','status',
+        'title'],
+    })
+  }
   browser.tabs.onRemoved.addListener(this.handlers.onTabRemoved)
   browser.tabs.onMoved.addListener(this.handlers.onTabMoved)
   browser.tabs.onDetached.addListener(this.handlers.onTabDetached)