API lambda adjustments #1666
Merged
API lambda adjustments #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Aug 1, 2025
|
|
||
| var app = builder.Build(); | ||
|
|
||
| var v1 = app.MapGroup("/v1"); | ||
| var v1 = app.MapGroup("/docs/_api/v1"); |
There was a problem hiding this comment.
We need a few reserved namespaces in the markdown build :). I have /docs/api for the OpenAPI too.
Mpdreamz
reviewed
Aug 1, 2025
| @@ -31,5 +31,4 @@ RUN arch=$TARGETARCH \ | |||
| && if [ "$arch" = "amd64" ]; then arch="x64"; fi \ | |||
| && echo $TARGETOS-$arch > /tmp/rid | |||
|
|
|||
| RUN dotnet publish src/infra/docs-lambda-index-publisher -r linux-x64 -c Release | |||
|
|
|||
| RUN dotnet publish src/infra/docs-lambda-index-publisher -r $(cat /tmp/rid) -c Release | |||
There was a problem hiding this comment.
Do we need to do the same here: https://github.com/elastic/docs-builder/blob/main/src/infra/docs-lambda-index-publisher/lambda.DockerFile ?
There was a problem hiding this comment.
Hehe, I unintentionally changed the wrong file..
I will keep as is, because it works.
reakaleek
force-pushed
the
feature/api-lambda-adjustments
branch
from
1845aaf to
fe1f37c
Compare
cloudfront is passing the full path to API gateway
…the INVOKE phase the ssm parameter lambda exention does not work at INIT time
reakaleek
force-pushed
the
feature/api-lambda-adjustments
branch
from
fe1f37c to
37f32ef
Compare
Mpdreamz
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Post adjustments to make the lambda work:
/docs/_apiprefix, because cloudfront passes the whole path to API gateway