Skip to content

Remove (current) from the version dropdown #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Removes (current) from the version dropdown to avoid confusion about which version is the latest now that the latest docs have been migrated to docs-builder and elastic.co/docs.

Screenshot 2025-04-25 at 8 45 04 AM

Note: This will remove (current) from version dropdowns in all books — even books that were not migrated to elastic.co/docs. Let me know if there are any concerns about this.

@colleenmcginnis colleenmcginnis self-assigned this Apr 25, 2025
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@lcawl
Copy link
Contributor

lcawl commented Apr 25, 2025

I wonder if we also want to add "noindex" to the current branches so they begin to retire from search sites? Currently it looks like we only have that option in conf.yaml at the book level, however.

@colleenmcginnis
Copy link
Contributor Author

I wonder if we also want to add "noindex" to the current branches so they begin to retire from search sites? Currently it looks like we only have that option in conf.yaml at the book level, however.

I think we should consult with the SEO team before doing this. @KOTungseth has this come up in any of your conversations?

@colleenmcginnis colleenmcginnis marked this pull request as ready for review April 25, 2025 15:50
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner April 25, 2025 15:50
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛵

@KOTungseth
Copy link
Contributor

I wonder if we also want to add "noindex" to the current branches so they begin to retire from search sites? Currently it looks like we only have that option in conf.yaml at the book level, however.

I think we should consult with the SEO team before doing this. @KOTungseth has this come up in any of your conversations?

@colleenmcginnis it's going to take a few weeks for Google to reindex. SEO is going to share insights when we have real data. Since 8.18 is not current, we should remove confusion by removing current from the /guide version dropdown.

@colleenmcginnis colleenmcginnis merged commit 3c015d9 into master Apr 28, 2025
5 checks passed
@colleenmcginnis colleenmcginnis deleted the remove-current-from-dropdown branch April 28, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants