Skip to content

[Backport 9.0] Minor improvement to fix in #3018 #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

[Backport 9.0] Minor improvement to fix in #3018 #3035

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions test_elasticsearch/test_server/test_rest_api_spec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,20 +495,14 @@ def remove_implicit_resolver(cls, tag_to_remove):
# Try loading the REST API test specs from the Elastic Artifacts API
try:
# Construct the HTTP and Elasticsearch client
http = urllib3.PoolManager(retries=10)
http = urllib3.PoolManager(retries=urllib3.Retry(total=10))

yaml_tests_url = (
"https://api.github.com/repos/elastic/elasticsearch-clients-tests/zipball/main"
)

# Download the zip and start reading YAML from the files in memory
package_zip = zipfile.ZipFile(
io.BytesIO(
http.request(
"GET", yaml_tests_url, retries=urllib3.Retry(3, redirect=10)
).data
)
)
package_zip = zipfile.ZipFile(io.BytesIO(http.request("GET", yaml_tests_url).data))

for yaml_file in package_zip.namelist():
if not re.match(r"^.*\/tests\/.*\.ya?ml$", yaml_file):
Expand Down