Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kibana_system user to manage .reindexed-v8-internal.alerts indices #118959

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Dec 18, 2024

Existing built-in roles can manage .internal.alerts* and .internal.preview.alerts* indices. If created in 7.x, these indices will be reindexed for the 9.0 upgrade and receive the .reindexed-v8 prefix so adding those patterns to the same roles.

@ymao1 ymao1 self-assigned this Dec 18, 2024
@ymao1 ymao1 added >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC auto-backport Automatically create backport pull requests when merged v8.18.0 labels Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @ymao1, I've created a changelog YAML for you.

@ymao1 ymao1 changed the title Adding reindexed alerts as data backing index prefixes Allow kibana_system user to manage .reindexed-v8-internal.alerts indices Dec 18, 2024
docs/changelog/118959.yaml Outdated Show resolved Hide resolved
@ymao1 ymao1 marked this pull request as ready for review December 18, 2024 17:45
@ymao1 ymao1 requested review from a team as code owners December 18, 2024 17:45
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Dec 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@jakelandis
Copy link
Contributor

If created in 7.x, these indices will be reindexed for the 9.0 upgrade

Shouldn't the result of the re-indexing via the Kibana upgrade assistant introduce an alias with the old name, which should allow continued access by the old name (without needing to add a new privilege) ?

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 18, 2024

If created in 7.x, these indices will be reindexed for the 9.0 upgrade

Shouldn't the result of the re-indexing via the Kibana upgrade assistant introduce an alias with the old name, which should allow continued access by the old name (without needing to add a new privilege) ?

Yes, for the most part this works. There is a specific portion of our code that uses the alias to retrieve all the concrete backing indices and directly updates the mappings on these backing indices and this is the issue we're trying to address.

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit dd02f74 into elastic:main Jan 2, 2025
21 checks passed
@ymao1 ymao1 deleted the reindexed-alerts branch January 2, 2025 14:25
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

ymao1 added a commit to ymao1/elasticsearch that referenced this pull request Jan 2, 2025
…indices (elastic#118959)

* Adding reindexed alerts as data backing index prefixes

* Update docs/changelog/118959.yaml

* Update docs/changelog/118959.yaml

---------

Co-authored-by: Ersin Erdal <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 2, 2025
…indices (#118959) (#119461)

* Adding reindexed alerts as data backing index prefixes

* Update docs/changelog/118959.yaml

* Update docs/changelog/118959.yaml

---------

Co-authored-by: Ersin Erdal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Security Meta label for security team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants