Add a replicate_for option to the ILM searchable_snapshot action #119003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>enhancement
WIP
:Data Management/ILM+SLM
dakrone
reviewed
Dec 23, 2024
| @@ -473,6 +474,77 @@ static void validateDownsamplingIntervals(Collection<Phase> phases) { | |||
| } | |||
| } | |||
|
|
|||
| static void validateReplicateFor(Collection<Phase> phases) { | |||
There was a problem hiding this comment.
Can you add a javadoc snippet for what this validation is going to this method?
| false, | ||
| new SingleMessageFieldInfo( | ||
| Strings.format( | ||
| "Waiting until the replicate_for time [%s] has elapsed for index [%s] before removing replicas.", |
There was a problem hiding this comment.
Think it'd be worth also including how long the calculated time is? So that a user can see "oh, it's waiting for 7 days and it's at 6 days right now"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
replicate_foroption (expressed as a time value) to the ILMsearchable_snapshotaction. If that option is present, then the searchable snapshot will be mounted with one replica (rather than zero replicas), and ILM execution will wait in the searchable snapshot action until thereplicate_fortime value has passed. Once the time value has passed, then the replica will be removed and execution will continue.As an example, this makes it possible to have a
frozenphase that lasts for 60 days, but to have 14 days worth of frozen data mounted with replicas.This is a draft pull request. I think the implementation side is complete -- it adds the new
replicate_foroption and also the policy validation rules around it. There are some unit tests, but I need to do the following still: